fix: settings in sidebar, better add project flow#584
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: (nothing to see here)
After:



Note
Move project creation to an inline panel in the Sidebar and add a Settings/Back footer control to support navigating to settings
Rework the
SidebarUI in Sidebar.tsx: add a header-level+toggle that opens an inline add-project panel with input, optional folder picker, loading state, cancel, and inline error text; replace footer add controls with aSettingsbutton when not on settings and aBackbutton when on settings; route state usesuseLocation; error handling inSidebar.addProjectFromPathsetsaddProjectErrorinstead of toasts and clears it on finish; focus returns to the input when folder picking is canceled.📍Where to Start
Start in the
Sidebarcomponent render and handlers in Sidebar.tsx, focusing onaddProjectFromPathand the new header-level add-project panel logic.Macroscope summarized d6f0350.