refactor(web): remove redundant double parse of diff route search params#598
Merged
t3dotgg merged 1 commit intopingdotgg:mainfrom Mar 9, 2026
Conversation
`rawSearch` is already the output of `parseDiffRouteSearch` via the `useSearch` select transform. The `useMemo` at line 760 re-parsed it through the same function with an unsafe `as Record<string, unknown>` cast, producing an identical result. Use `rawSearch` directly instead.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rawSearchinChatViewis produced byuseSearchwith aselecttransform that runsparseDiffRouteSearch. A subsequentuseMemore-parsed the already-parsed result through the same function using an unsafeas Record<string, unknown>cast, producing an identicalDiffRouteSearchobject.This removes the redundant
useMemo+ re-parse and readsrawSearch.diffdirectly, sincerawSearchis already typed asDiffRouteSearch.Change
diffSearchuseMemo that calledparseDiffRouteSearch(rawSearch as Record<string, unknown>)diffSearch.diff === "1"withrawSearch.diff === "1"Verification
bun lint— passes (only pre-existing warnings)bun typecheck— passes across all 7 packagesbun run test— passes (pre-existingterminalStateStore.test.tsfailures unrelated)Note
Remove redundant double parse of diff route search params by deriving
ChatViewdiff state directly fromrawSearch.diffin ChatView.tsxRemove
useMemofordiffSearchand computediffOpendirectly fromrawSearch.diffin ChatView.tsx.📍Where to Start
Start with the
ChatViewcomponent changes in ChatView.tsx.Macroscope summarized a7a2fae.