Fix ChatView header overflow for long thread titles#60
Merged
juliusmarminge merged 2 commits intomainfrom Feb 18, 2026
Merged
Conversation
- add `min-w-0` to ChatView container wrappers to allow proper flex shrinking - make thread title truncatable with `truncate` and `title` tooltip - keep action controls fixed-width with `shrink-0` to preserve header layout
WalkthroughAdds a MAX_THREAD_TERMINAL_COUNT limit (value 4) and enforces it across UI and store: ChatView and ThreadTerminalDrawer now guard split/new terminal actions and adjust layout/labels when the cap is reached; store normalization and reducers prevent creating terminals beyond the cap; tests added to validate behavior. Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant UI as ThreadTerminalDrawer / ChatView
participant Store as Store (reducers)
User->>UI: Click "Split" or "New Terminal"
UI->>UI: check hasReachedTerminalLimit (reads terminals count)
alt limit reached
UI-->>User: no-op, show disabled state / label indicating max
else below limit
UI->>Store: dispatch SPLIT_THREAD_TERMINAL / NEW_THREAD_TERMINAL
Store->>Store: normalize terminals, enforce MAX_THREAD_TERMINAL_COUNT
alt store accepted
Store-->>UI: updated state with new terminal
UI-->>User: render new terminal
else rejected (would exceed)
Store-->>UI: state unchanged
UI-->>User: maintain current UI (action prevented)
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Contributor
Prevent ChatView header overflow for long thread titles and cap thread terminals at 4 across UI actions and store logicIntroduce 📍Where to StartStart with the terminal cap logic in the reducers in store.ts, then review header truncation and overflow fixes in ChatView.tsx. Macroscope summarized dcc6d9d. |
Greptile SummaryFixes header overflow in
Confidence Score: 5/5
Important Files Changed
Flowchartflowchart TD
A["Layout (flex h-screen overflow-hidden)"] --> B["Sidebar"]
A --> C["ChatView (flex-1 min-w-0)"]
A --> D["DiffPanel (conditional)"]
C --> E["header (flex justify-between)"]
C --> F["Messages area"]
E --> G["Left: title container (flex-1 min-w-0)"]
E --> H["Right: actions (shrink-0)"]
G --> I["h2 thread title (truncate + title tooltip)"]
G --> J["Badge project name (shrink-0)"]
H --> K["OpenInPicker / GitActions / Diff button"]
Last reviewed commit: 0a4c070 |
- enforce max 4 terminals per thread in reducer and terminal normalization - block split/new terminal actions in chat and drawer when limit is reached - add reducer tests for split/new terminal cap behavior
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/web/src/components/ThreadTerminalDrawer.tsx (1)
718-740: Consider addingaria-disabledfor better accessibility.The buttons are visually styled as disabled but don't communicate this state to assistive technologies. While the tooltip message helps, adding
aria-disabled="true"whenhasReachedTerminalLimitwould improve screen reader accessibility.♿ Proposed accessibility improvement
<TerminalActionButton className={`p-1 text-foreground/90 transition-colors ${ hasReachedTerminalLimit ? "cursor-not-allowed opacity-45 hover:bg-transparent" : "hover:bg-accent" }`} onClick={onSplitTerminalAction} label={splitTerminalActionLabel} + aria-disabled={hasReachedTerminalLimit} >Note: This would require updating the
TerminalActionButtonPropsinterface to accept an optionalaria-disabledprop and pass it through to the button element.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/components/ThreadTerminalDrawer.tsx` around lines 718 - 740, The TerminalActionButton instances should convey the disabled state to assistive tech: update the TerminalActionButton component and its TerminalActionButtonProps to accept an optional aria-disabled boolean prop, pass that prop through to the underlying button element, and set aria-disabled={hasReachedTerminalLimit} on both usages (the SquareSplitHorizontal and Plus buttons) when the visual disabled styling is applied; ensure the existing onClick still respects the disabled state (no-op or prevented) to match aria-disabled.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@apps/web/src/components/ThreadTerminalDrawer.tsx`:
- Around line 718-740: The TerminalActionButton instances should convey the
disabled state to assistive tech: update the TerminalActionButton component and
its TerminalActionButtonProps to accept an optional aria-disabled boolean prop,
pass that prop through to the underlying button element, and set
aria-disabled={hasReachedTerminalLimit} on both usages (the
SquareSplitHorizontal and Plus buttons) when the visual disabled styling is
applied; ensure the existing onClick still respects the disabled state (no-op or
prevented) to match aria-disabled.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
|
Bugbot Autofix prepared fixes for 1 of the 1 bugs found in the latest run.
Or push these changes by commenting: Preview (cfabf9bd03)diff --git a/apps/web/src/components/ThreadTerminalDrawer.tsx b/apps/web/src/components/ThreadTerminalDrawer.tsx
--- a/apps/web/src/components/ThreadTerminalDrawer.tsx
+++ b/apps/web/src/components/ThreadTerminalDrawer.tsx
@@ -755,9 +755,9 @@
<div className="min-w-0 flex-1">
{isSplitView ? (
<div
- className="grid h-full w-full min-w-0 gap-0 overflow-hidden"
+ className="grid h-full w-full min-w-0 gap-0 overflow-x-auto"
style={{
- gridTemplateColumns: `repeat(${visibleTerminalIds.length}, minmax(0, 1fr))`,
+ gridTemplateColumns: `repeat(${visibleTerminalIds.length}, minmax(260px, 1fr))`,
}}
>
{visibleTerminalIds.map((terminalId) => ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
min-w-0to ChatView container wrappers so header content can shrink within flex layoutsflex-1 min-w-0and applytruncateto the thread titletitletooltip on the truncated thread name to preserve full-title visibilityshrink-0so controls remain stable when titles are longTesting
Summary by CodeRabbit
New Features
Improvements
Tests
Note
Low Risk
Mostly UI/layout tweaks plus a straightforward terminal-count cap with added reducer guards and tests; limited blast radius to thread terminal management and display.
Overview
Fixes chat header layout issues with long thread titles by adding
min-w-0/truncateand a hovertitletooltip, and by marking the actions area asshrink-0so controls don’t get pushed off-screen.Introduces a shared
MAX_THREAD_TERMINAL_COUNT(set to 4) and enforces it end-to-end: UI actions for split/new terminals are disabled with updated tooltips when at the cap, the reducer ignores attempts to add beyond the limit (including on hydration/normalization), and new tests cover both split and new terminal capping behavior.Written by Cursor Bugbot for commit dcc6d9d. This will update automatically on new commits. Configure here.