feat: use static appimage runtime for Linux#715
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughA new AppImage toolset entry Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
scripts/build-desktop-artifact.ts (1)
476-478: Document this temporary runtime pin inline.The rationale and removal condition currently only live in the PR description, so
1.0.2will read like a magic value later. A short TODO here will make future electron-builder upgrades safer.📝 Suggested change
if (platform === "linux") { buildConfig.linux = { target: [target], icon: "icon.png", category: "Development", }; + // TODO: Remove this once electron-builder defaults to the static AppImage runtime. + // Ubuntu 22.04+ does not install libfuse2 by default, so we pin the static runtime here. buildConfig.toolsets = { appimage: "1.0.2", }; }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/build-desktop-artifact.ts` around lines 476 - 478, Add an inline TODO comment next to the buildConfig.toolsets assignment that pins appimage to "1.0.2": explain this is a temporary runtime pin for electron-builder compatibility (reference the PR rationale) and state the removal condition (e.g., when electron-builder supports newer appimage runtime or after testing X version), and include a short date/author or PR number for traceability so the magic value in buildConfig.toolsets.appimage is self-documented.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@scripts/build-desktop-artifact.ts`:
- Around line 476-478: Add an inline TODO comment next to the
buildConfig.toolsets assignment that pins appimage to "1.0.2": explain this is a
temporary runtime pin for electron-builder compatibility (reference the PR
rationale) and state the removal condition (e.g., when electron-builder supports
newer appimage runtime or after testing X version), and include a short
date/author or PR number for traceability so the magic value in
buildConfig.toolsets.appimage is self-documented.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: cbad2f35-39ac-4fd7-938b-1185ba9f4547
📒 Files selected for processing (1)
scripts/build-desktop-artifact.ts
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
What Changed
uses electron-userland/electron-builder#9558 to use static appimage runtime
Why
Problem: libfuse2 is not installed on Ubuntu 22.04 and later
electron-userland/electron-builder#9632
When electron-builder enables this by default, this workaround should be removed
Checklist
Note
Use static AppImage runtime for Linux desktop builds
Sets
toolsets.appimageto"1.0.2"in the Linux branch ofcreateBuildConfigin build-desktop-artifact.ts, switching Linux builds to use a static AppImage runtime.Macroscope summarized 7f847d8.
Summary by CodeRabbit