feat: Allow Overriding Timestamp Format in Settings#855
feat: Allow Overriding Timestamp Format in Settings#855juliusmarminge merged 7 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
713c11a to
e02b780
Compare
There was a problem hiding this comment.
looks like rebase went wrong here?
There was a problem hiding this comment.
Yes you caught me in the middle of a cleanup, it should look beter now :)
|
as a form of future proofing i'd probably go for a string based format selector. boolean flags are kinda shit and tends to not scale 😆 |
4383fc7 to
0eb7e8f
Compare






What Changed
Adds a 24-hour timestamp setting and applies it across chat, diffs, and plan timestamps. It also centralizes timestamp formatting and makes the setting persist safely across reloads.
Why
Timestamps were previously fixed to 12-hour format. Many users, especially outside the US, expect 24-hour time by default or strongly prefer it. This adds a simple preference and applies it consistently across the app without duplicating formatting logic.
UI Changes
Before: screenshot showing 12-hour timestamps in the chat UI

After: screenshot showing 24-hour timestamps in the same UI

Settings: screenshot showing the new Use 24-hour timestamps toggle in Settings

Checklist
Note
Add 24-hour, 12-hour, and locale timestamp format options to app settings
timestampFormatsetting ('locale'|'12-hour'|'24-hour') toappSettings.ts, defaulting to'locale'.timestampFormat.tswithformatTimestampandformatShortTimestamputilities that build cachedIntl.DateTimeFormatinstances per format and seconds-inclusion.timestampFormatfromChatViewdown toMessagesTimelineandPlanSidebar, and applies it inDiffPanel, replacing the previously scattered local formatting logic._chat.settings.tsx.formatTimestampis removed fromsession-logic.ts; all callers must now use the new module.Macroscope summarized f17bf3f.