feat: im#4
Merged
Merged
Conversation
- Reorganize api/gen directory structure by language - Create api/gen/go/, api/gen/java/, api/gen/typescript/ directories - Add Go module configuration in api/gen/go/go.mod - Add TypeScript package configuration in api/gen/typescript/ - Create new proto-generator-new.sh script for centralized generation - Update Makefile to use new script and directory structure - Generate all proto code to centralized locations - Add comprehensive README.md documentation This change simplifies the build process by: - Eliminating per-service proto generation - Reducing Docker image sizes (no protoc needed) - Improving build times (no proto compilation in Docker) - Centralizing all generated code in one location
- Install protoc-gen-grpc-java plugin - Generate all Java protobuf code to api/gen/java/ - Code organized by package: com.pingxin403.cuckoo and com.myorg.api - All proto files successfully compiled to Java classes - Ready for Java services to use centralized generated code
- Updated all Go services to use api/gen/go/* imports - Updated go.mod files to reference api/gen/go module - Simplified Dockerfiles by removing protoc installation - Removed local gen/ directories from all Go services - All tests passing Services migrated: - auth-service - user-service - im-service - im-gateway-service This completes Phase 2 of the centralized proto generation migration.
- Updated all proto files to use consistent java_package naming
- Changed hello.proto and todo.proto from com.myorg.api.v1 to com.pingxin403.cuckoo.{service}.v1
- Changed shortener_service.proto from com.pingxin403.api.v1 to com.pingxin403.cuckoo.shortener.v1
- Updated all proto files to use centralized go_package paths (api/gen/go/*)
- Regenerated all proto code for Go, Java, and TypeScript
- Removed old com/myorg and com/pingxin403/api directories
- Updated hello-service Java imports (service and test files) to use new package names
- All Java code now under com/pingxin403/cuckoo/* for consistency
- All tests passing (Java, Go, TypeScript)
- Renamed im_gateway_service.proto -> gateway.proto - Renamed shortener_service.proto -> shortener.proto - Updated go_package to use shorter names (gatewaypb, shortenerpb) - Migrated shortener-service to centralized proto generation - Updated all import paths in shortener-service - Simplified Dockerfile (removed protoc installation) - All tests passing
… naming - Renamed api/v1/gateway.proto to api/v1/im-gateway.proto for clarity - Updated go_package to use im-gatewaypb instead of gatewaypb - Updated proto generation script to map im-gateway -> im-gatewaypb - Updated proto generation script to map shortener -> shortenerpb - Regenerated all proto code with new directory structure - Cleaned up old generated files Directory structure now: - api/gen/go/im-gatewaypb/ (was gatewaypb/) - api/gen/go/shortenerpb/ (was shortener_servicepb/) - api/gen/typescript/im-gatewaypb/ (was gatewaypb/) - api/gen/typescript/shortenerpb/ (was shortener_servicepb/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issues
Fixes #
Related to #
Changes Made
Services Affected
Testing
Unit Tests
Integration Tests
Manual Testing
Checklist
Protobuf Changes (if applicable)
api/v1/make prototo generate code for all languagesmake verify-protopassesDocumentation (if applicable)
Screenshots (if applicable)
Additional Notes
Reviewer Notes
For Reviewers: