Xcode 12.5 / SPM - Add missing headers to fix build errors #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Is anyone else seeing this issue with Xcode 12.5? |
|
Also seeing this. Building against a Swift target succeeded but UIKit dependent classes (like |
Contributor
Author
|
Can we get this merged? |
Contributor
Author
|
Thank you @garrettmoon! |
annomusa
added a commit
to annomusa/PINRemoteImage
that referenced
this pull request
Dec 17, 2021
* master-pinremoteimage: Disable asserts in release builds when using Swift Package Manager unarchiveObjectWithData: and archivedDataWithRootObject: are deprecated (pinterest#610) update comment Set cachePolicy accordingly when PINRemoteImageManagerDownloadOptionsIgnoreCache is provided Decode WebP images directly into a buffer Core Animation likes (pinterest#600) Xcode 12.5 / SPM - Add missing headers to fix build errors with SPM and Xcode 12.5 (pinterest#597) Fixed spm integration on regular Xcode project (pinterest#586) Fix PINRemoteImageManager.h Close Comment Formatting (pinterest#594) Fix typo in PINRemoteImageManager.html (pinterest#593) Carthage is broken on Xcode 12 (pinterest#584) Update podspec to match release Hopefully fix publish for real this time... # Conflicts: # Package.swift
|
could i request a 3.0.4 release ? |
Lilfaen
pushed a commit
to Lilfaen/PINRemoteImage
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this just showed up in the final build of Xcode 12.5 but we're seeing builds errors this in our own project and in the the
Example-Xcode-SPMsample project.I've included the missing headers and it seems to fix the issues for us but not sure if I have impacted Carthage or Cocoapods.
The PINRemoteImage package itself builds fine, but the UIKit classes and extensions are not being exposed resulting in errors like: