Update permissions check when executing batch of query_executions#1671
Merged
jasoncoffman merged 2 commits intopinterest:masterfrom Mar 13, 2026
Merged
Conversation
kgopal492
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a stricter environment permission check and applies it to the batch data cell executions endpoint. Also removes unnecessary manual DBSession management and adds unit tests for the new permission function.
Problem
The
/batch/data_cell/query_execution/endpoint usesverify_data_cells_permissionto authorize access. That function calledverify_environment_permission, which only checks that the user has access to at least one of the environments associated with the requested cells. This means a user with access to environment A but not environment B could batch-request cells spanning both environments and still pass the permission check.Solution
verify_every_environment_permissionin permission.py, which asserts the user has access to all provided environment IDs.verify_data_cells_permissionto callverify_every_environment_permissionso batch requests are only allowed when the user has access to every environment involved.verify_environment_permissionandverify_every_environment_permissionto clarify the distinction.batch_get_data_cell_executionsin datadoc.py, relying on the default session handling instead.Test Plan