Skip to content

Support ast.Position column numbers#17

Merged
jparise merged 1 commit intomainfrom
parse-error-cols
Jun 28, 2021
Merged

Support ast.Position column numbers#17
jparise merged 1 commit intomainfrom
parse-error-cols

Conversation

@jparise
Copy link
Copy Markdown
Collaborator

@jparise jparise commented Jun 28, 2021

These are currently only available for parse errors, but wider
node-level support will come next.

We continue to display 1 (instead of 0) in our message output when
column information isn't available.

These are currently only available for parse errors, but wider
node-level support will come next.

We continue to display 1 (instead of 0) in our message output when
column information isn't available.
@jparise jparise added the enhancement New feature or request label Jun 28, 2021
@jparise jparise merged commit c2cbaba into main Jun 28, 2021
@jparise jparise deleted the parse-error-cols branch June 28, 2021 22:49
Tiny-Box pushed a commit to Tiny-Box/thriftcheck that referenced this pull request Feb 22, 2023
These are currently only available for parse errors, but wider
node-level support will come next.

We continue to display 1 (instead of 0) in our message output when
column information isn't available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant