Conversation
We were previously using the including file's name, which I mistakenly thought was the `thrift` compiler's behavior. We instead need to add the current directory as the first search path to match `thrift`. This change also adds support for absolute paths and makes consistent use of the `path/filepath` package for better cross-platform support.
jparise
added a commit
that referenced
this pull request
Aug 27, 2021
This reverts part of the changes introduced in #24: we want to include the file's directory in our search path, not the process's current working directory. In fixing this, I realized that we can simply build the list of search directories once as part of the linting context. This further simplifies the downstream code while also making this less error prone.
jparise
added a commit
that referenced
this pull request
Aug 27, 2021
This reverts part of the changes introduced in #24: we want to include the file's directory in our search path, not the process's current working directory. In fixing this, I realized that we can simply build the list of search directories once as part of the linting context. This further simplifies the downstream code while also making this less error prone.
Tiny-Box
pushed a commit
to Tiny-Box/thriftcheck
that referenced
this pull request
Feb 22, 2023
We were previously using the including file's name, which I mistakenly thought was the `thrift` compiler's behavior. We instead need to add the current directory as the first search path to match `thrift`. This change also adds support for absolute paths and makes consistent use of the `path/filepath` package for better cross-platform support.
Tiny-Box
pushed a commit
to Tiny-Box/thriftcheck
that referenced
this pull request
Feb 22, 2023
This reverts part of the changes introduced in pinterest#24: we want to include the file's directory in our search path, not the process's current working directory. In fixing this, I realized that we can simply build the list of search directories once as part of the linting context. This further simplifies the downstream code while also making this less error prone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were previously using the including file's name, which I mistakenly
thought was the
thriftcompiler's behavior. We instead need to add thecurrent directory as the first search path to match
thrift.This change also adds support for absolute paths and makes consistent
use of the
path/filepathpackage for better cross-platform support.