Skip to content

submodules updater and test builds#12

Merged
pinterf merged 2 commits into
pinterf:masterfrom
seiya-dev:github-actions
May 21, 2022
Merged

submodules updater and test builds#12
pinterf merged 2 commits into
pinterf:masterfrom
seiya-dev:github-actions

Conversation

@seiya-git
Copy link
Copy Markdown

For test builds and checking submodule updates for master branch
(should be merged after SMP folder update #11)

@seiya-git seiya-git force-pushed the github-actions branch 2 times, most recently from 7b1c4d1 to f8d8510 Compare May 14, 2022 12:30
@realfinder
Copy link
Copy Markdown

realfinder commented May 14, 2022

don't know if this use GCC or Windows Visual Studio, but I think it's better to make it use GCC so it can be build for Linux and cross-compiled for windows from Linux (since it's C-plugin) and use source code from last official libass commits and other libraries

@seiya-git
Copy link
Copy Markdown
Author

seiya-git commented May 14, 2022

@realfinder, GCC is used for Linux Ubuntu and Visual Studio MSBuild for Windows
I can't build mingw64 version for windows, it's says avisynth is missing, but lib in correct directory
https://github.com/pinterf/assrender/blob/master/src/CMakeLists.txt#L39

@seiya-git
Copy link
Copy Markdown
Author

seiya-git commented May 14, 2022

@realfinder, Added Windows GCC github build script, but it's not working

@seiya-git seiya-git force-pushed the github-actions branch 2 times, most recently from 7d6d22a to e8c6b9a Compare May 14, 2022 15:21
@realfinder
Copy link
Copy Markdown

realfinder commented May 14, 2022

@realfinder, Added Windows GCC github build script, but it's not working

how it not working? anyway let see what @qyot27 will said

@seiya-git seiya-git force-pushed the github-actions branch 5 times, most recently from 731eda1 to aee223e Compare May 15, 2022 09:35
@realfinder
Copy link
Copy Markdown

still not get it to work? C API cross-compiles should be fine AviSynth/AviSynthPlus#281

@seiya-git
Copy link
Copy Markdown
Author

@realfinder yes, mingw build not work and I don't know how to fix it, anyway we have Visual Studio build

@pinterf
Copy link
Copy Markdown
Owner

pinterf commented May 18, 2022

Since #11 is merged, should this one be merged as well or we can expect further changes?

@seiya-git
Copy link
Copy Markdown
Author

@pinterf can we split README.md to BUILD.md, CHANGELOG.md and README.md with links in README.md to BUILD.md and CHANGELOG.md?

@pinterf
Copy link
Copy Markdown
Owner

pinterf commented May 21, 2022

Definitely yes.

@seiya-git seiya-git force-pushed the github-actions branch 2 times, most recently from 6feb9af to 7bf9a82 Compare May 21, 2022 07:11
@seiya-git
Copy link
Copy Markdown
Author

@pinterf done! Everything works now, you can merge it.
I commented mingw64 build in GitHub CI since it's not working outside the msys2 for now

@pinterf pinterf merged commit ae23131 into pinterf:master May 21, 2022
@seiya-git seiya-git deleted the github-actions branch May 21, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants