Skip to content

ShipmentPlanner Into Facet #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
default-juice merged 2 commits into from
Oct 11, 2025
Merged

ShipmentPlanner Into Facet #153

default-juice merged 2 commits into from
Oct 11, 2025

Conversation

@default-juice
Copy link
Contributor

@default-juice default-juice commented Oct 6, 2025 •
edited
Loading

  • Tuns ShipmentPlanner into a diamond facet.
  • Follows a similar pattern as the BDVFacet where if the planContract is set to address(0) upon initialization of new routes, it is turned into address(this) so that the external plan functions are invoked on the diamond.
  • Adjusts beanstalk shipments deployment flow to omit deployment of the external contract which updates the expected nonces.
  • Sunt.t.sol now tests both if the plan contract lives on the diamond or is external

@default-juice default-juice mentioned this pull request Oct 6, 2025
Open
@fr1jo
Copy link
Contributor

fr1jo commented Oct 10, 2025

lgtm! can we merge this?

@default-juice default-juice merged commit 2542fe7 into beanstalk-shipments Oct 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@default-juice @fr1jo