Fix small typo in transformation docs #1278
Conversation
pints/_transformation.py
Outdated
| r""" | ||
| A generalised version of the logit transformation for the model parameters, | ||
| which transform an interval or rectangular boundaries :math:`[a, b)` to | ||
| which transform an interval or rectangular boundaries :math:`(a, b)` to |
There was a problem hiding this comment.
transform -> transforms.
Is it a () interval then, not a half-open one?
There was a problem hiding this comment.
But you're saying the interval doesn't include a then? So it's an open rather than a half-open interval?
There was a problem hiding this comment.
Ha, need correcting that line too! 😄
There was a problem hiding this comment.
It's an open () interval. I think now the docs is consistent...?
There was a problem hiding this comment.
:D Are you sure? The rectangular boundaries docs say they define a half-open interval https://pints.readthedocs.io/en/stable/boundaries.html#pints.RectangularBoundaries
There was a problem hiding this comment.
Oh... didn't realise that!
There was a problem hiding this comment.
I can't remember the reason - why do we want to include the lower bound?
There was a problem hiding this comment.
Not sure, but maybe a separate ticket then? This can just fix the missing "s" and test :D :D :D
|
Tests are failing. I see Ben has a fix here: https://github.com/pints-team/pints/pull/1058/files Maybe stick this fix in this PR too? Makes more sense here :D |
|
Michael did you mean stick this fix (https://github.com/pints-team/pints/pull/1058/files#diff-43f514bb09c1eb58423de94253a01bf25b3232f4324e4a9d8606ee6db00039b5R160) to here? |
Yes please! |
Codecov Report
@@ Coverage Diff @@
## master #1278 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 84 84
Lines 8823 8823
=========================================
Hits 8823 8823
Continue to review full report at Codecov.
|
Fix #1277