Skip to content

Make it possible to conditionally insert attributes#914

Merged
fippo merged 1 commit into
pion:mainfrom
fippo:flexible-attributes
Apr 25, 2026
Merged

Make it possible to conditionally insert attributes#914
fippo merged 1 commit into
pion:mainfrom
fippo:flexible-attributes

Conversation

@fippo

@fippo fippo commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

which will be used in #876 where the presence of some
attributes depends on whether they were used in the
original request.

(split from that to make review simpler, no functional changes)

@codecov

codecov Bot commented Apr 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.57%. Comparing base (ceccc15) to head (4a5d40b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
agent.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #914      +/-   ##
==========================================
+ Coverage   88.52%   88.57%   +0.05%     
==========================================
  Files          45       45              
  Lines        5872     5884      +12     
==========================================
+ Hits         5198     5212      +14     
+ Misses        463      462       -1     
+ Partials      211      210       -1     
Flag Coverage Δ
go 88.57% <93.54%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread agent.go Outdated
@fippo fippo marked this pull request as ready for review April 24, 2026 12:09
@fippo fippo requested a review from JoTurk April 24, 2026 17:16
@fippo fippo force-pushed the flexible-attributes branch 3 times, most recently from 7d83822 to 1439985 Compare April 25, 2026 17:41
Comment thread agent.go Outdated
@fippo fippo force-pushed the flexible-attributes branch 2 times, most recently from df5aa48 to e613086 Compare April 25, 2026 17:47
which will be used in pion#876 where the presence of some
attributes depends on whether they were used in the
original request.
@fippo fippo force-pushed the flexible-attributes branch from e613086 to 4a5d40b Compare April 25, 2026 17:54
@fippo fippo merged commit d94afce into pion:main Apr 25, 2026
18 checks passed
@fippo fippo deleted the flexible-attributes branch April 25, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants