Make it possible to conditionally insert attributes#914
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #914 +/- ##
==========================================
+ Coverage 88.52% 88.57% +0.05%
==========================================
Files 45 45
Lines 5872 5884 +12
==========================================
+ Hits 5198 5212 +14
+ Misses 463 462 -1
+ Partials 211 210 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0c96ed5 to
36cee05
Compare
fippo
commented
Apr 24, 2026
JoTurk
approved these changes
Apr 25, 2026
7d83822 to
1439985
Compare
JoTurk
reviewed
Apr 25, 2026
df5aa48 to
e613086
Compare
which will be used in pion#876 where the presence of some attributes depends on whether they were used in the original request.
e613086 to
4a5d40b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which will be used in #876 where the presence of some
attributes depends on whether they were used in the
original request.
(split from that to make review simpler, no functional changes)