Skip to content

Remove unused named return parameters #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cppcoffee merged 1 commit into from
Aug 11, 2025
Merged

Remove unused named return parameters #354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/twcc/arrival_time_map.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,13 @@ func (m *packetArrivalTimeMap) EndSequenceNumber() int64 {
}

// FindNextAtOrAfter returns the sequence number and timestamp of the first received packet that has a sequence number
// greator or equal to sequenceNumber.
// greater or equal to sequenceNumber.
func (m *packetArrivalTimeMap) FindNextAtOrAfter(sequenceNumber int64) (
foundSequenceNumber int64, arrivalTime int64, ok bool,
Copy link
Member

@JoTurk JoTurk Aug 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change but I think it makes this function slightly less readable from foundSequenceNumber int64, arrivalTime int64, ok bool int64, int64, bool, maybe we can move this to the function comment? or name the local variables to foundSequenceNumber and arrivalTime instead of seq and t.

Copy link
Member Author

@cppcoffee cppcoffee Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps designating them 'seq' and 'arrivalTime' would ensure adherence to the 72-character constraint.

int64, int64, bool,
) {
for sequenceNumber = m.Clamp(sequenceNumber); sequenceNumber < m.endSequenceNumber; sequenceNumber++ {
if t := m.get(sequenceNumber); t >= 0 {
return sequenceNumber, t, true
for seq := m.Clamp(sequenceNumber); seq < m.endSequenceNumber; seq++ {
if arrivalTime := m.get(seq); arrivalTime >= 0 {
return seq, arrivalTime, true
}
}

Expand Down
Loading