Draft ICE#23
Merged
xinze-zheng merged 8 commits intomainfrom Nov 14, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage ? 84.69%
=======================================
Files ? 11
Lines ? 882
Branches ? 0
=======================================
Hits ? 747
Misses ? 114
Partials ? 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoTurk
approved these changes
Nov 10, 2025
Member
There was a problem hiding this comment.
Overall great draft that we can work on. I would like to see / add:
- RFC 7064/7065 addresses for turn / stun settings.
- /healthz + metrics.
- clear IPv6 support.
- more coverage.
But this is a good base that we can work on, after you merge our PR i'm going to add few PRs to add some features on top of it.
Really great work, thank you..
|
|
||
| tlsLn := tls.NewListener(baseLn, &tls.Config{ | ||
| Certificates: []tls.Certificate{cert}, | ||
| MinVersion: tls.VersionTLS12, |
Member
There was a problem hiding this comment.
Nit: I would like to be able to configure TLS versions.
| // makeRelay returns the RelayAddressGenerator for configuration. | ||
| func makeRelay(cfg ionICE.TURNConfig) turn.RelayAddressGenerator { | ||
| return &turn.RelayAddressGeneratorPortRange{ | ||
| Address: "0.0.0.0", |
Member
There was a problem hiding this comment.
We should be able to configure the relay address.
Member
Author
|
Configs now calls a validation check for valid fields, endpoint, non empty fields, etc. during load. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a draft for TURN STUN sidecar for ION. I'm hoping to have some feedbacks before proceeding.
TODO
Reference issue
Fixes #20 #21