Implement Opus packet frame parsing#89
Merged
zshang-oai merged 1 commit intopion:masterfrom Mar 25, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
===========================================
+ Coverage 61.10% 72.96% +11.85%
===========================================
Files 8 8
Lines 1085 1202 +117
===========================================
+ Hits 663 877 +214
+ Misses 396 292 -104
- Partials 26 33 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Hey @zshang-oai this is great! I would love to get full CELT decode + CELT encode. You won't need SILK so don't worry about that :) |
Member
|
Can you update your commit message to be your GitHub message from above and fix the lints, then its good to merge! |
f9bb025 to
2a3242c
Compare
Contributor
Author
|
@Sean-Der I updated the PR, can you check again? |
Sean-Der
approved these changes
Mar 25, 2026
Implement Opus packet frame parsing for codes 0, 1, 2, and 3. Enforce RFC 6716 malformed packet rules R1-R7, fix TOC config/frame-duration parsing bugs used by packet validation, and add packet parser tests covering malformed rules and zero-length edge cases. Validation: - go test ./... -count=1 - golangci-lint run
2a3242c to
740b14b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(The code was created by Codex, but a human reviewed it line by line and verified it with RFC word by word)
Validation