-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix MIME type comparisons to be case-insensitive #3085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3085 +/- ##
==========================================
- Coverage 78.74% 78.72% -0.02%
==========================================
Files 91 91
Lines 11401 11401
==========================================
- Hits 8978 8976 -2
- Misses 1935 1937 +2
Partials 488 488
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This looks great to me @San9H0! would you mind adding a simple test? Just to make sure no one breaks your fix |
5c070c0 to
5ca0470
Compare
|
Thanks for the review! I've added a test case to verify the case-insensitive MIME type comparison. Let me know if you need any changes. |
|
Thank you :) |
32a4661 to
e4863c8
Compare
|
@San9H0 is it ready? :) |
|
OK. It's all done on my side. Let me know if anything else is needed |
|
Can we call (Mistakenly closed this for a second because I hit the wrong button when I tried to comment, sorry about that) |
I agree that would make much more sense Edit: after tests, this would wouldn't be simple, sadly, it would break some things that rely on the current behavior, but we can do it later. |
3d489e8 to
c0bb88d
Compare
c0bb88d to
3e2a804
Compare
Description
The
RegisterCodecfunction is public and takes the mimeType as a string. Therefore, it should compare values using strings.EqualFold.In general, MIME type comparisons should be done in a case-insensitive manner.
Reference issue
Fixes #...