Examples: extend sfu-ws with data-channel broadcasting #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2617
💛 - Coveralls |
pawsengineer
force-pushed
the
broadcast-datachannel
branch
from
b3f9166 to
ce0a800
Compare
Member
|
Hey @imalic3 really nice work! You are hitting some errors in CI, you can see them here To re-create those errors locally you can run the commands from our travis.yml When |
pawsengineer
force-pushed
the
broadcast-datachannel
branch
3 times, most recently
from
4e45fab to
cae908a
Compare
pawsengineer
force-pushed
the
broadcast-datachannel
branch
from
cae908a to
420b20f
Compare
Member
Author
|
@Sean-Der, the issue has been fixed. Thank you again for your awesome work :). |
Sean-Der
approved these changes
Mar 22, 2019
Member
Sean-Der
left a comment
Sean-Der
left a comment
There was a problem hiding this comment.
Fantastic work, thanks for working on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing with sfu-ws and trying to improve the example with data-channel broadcasting.
Relates to #534