Overriding generated systems in a mod. Generated systems are not replaced.

[syonfox]

Observed behavior

When customizing a system ie

~/pioneer/mods/mymod/systems/custom/21_ganinil.json

21_ganinil.json

The both systems are shown.

Expected behavior

A system with the same name and sector should replace a generated system.

Steps to reproduce

Modify a system with the editor by clicking new system searching for a systems and saving the json.

Place it in the custom systems folder.

Now there will be 2 systems with that name in the galaxy view

output.txt
(#6012)

[syonfox]

I think this is because the custom systems database is separate from the generated systems database.

If I have 2 custom systems with the same name then only one of them is shown so it seems to override.

[sturnclaw]

IIRC the ability to override existing custom systems was added with the system editor, but overriding randomly-generated systems is more tricky and was reserved for a future pass on how random systems are generated (and how the game determines if they're populated, etc.)

This problem will likely have to be tackled after the upcoming release however.

[syonfox]

I need to confirm but the only systems a mod could override then are the custom systems definitions. (by overwriting the file when the mod folder is copied to data.)

This could be used to update the partial system db as well in theory I spouses.

A hack might be to allow lua to delete systems from the generated system table. the trick would be for this not to cause weird side effects.