Skip to content

fix(gateway): close unresolved review risks and simplify#9

Merged
pionxe merged 1 commit intorelease/v2.0-split-buildfrom
fork-pr-423-1776999056
Apr 24, 2026
Merged

fix(gateway): close unresolved review risks and simplify#9
pionxe merged 1 commit intorelease/v2.0-split-buildfrom
fork-pr-423-1776999056

Conversation

@fennoai
Copy link
Copy Markdown

@fennoai fennoai Bot commented Apr 24, 2026

Requested by @pionxe

Summary

  • tighten gateway launcher executable path constraints to reduce unsafe PATH execution risk
  • align waitGatewayReady timeout error message with effective deadline window
  • add gateway RPC docs consistency checker and wire it into docs-gateway-check
  • simplify touched code paths without changing behavior

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: pionxe <148670367+pionxe@users.noreply.github.com>
@fennoai
Copy link
Copy Markdown
Author

fennoai Bot commented Apr 24, 2026

Important

Configuration Required

No API key has been configured for this organization. XGopilot requires an API key to process requests.

Please visit the Settings page to configure your API key.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 91.05263% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
scripts/check_gateway_docs/main.go 72.72% 10 Missing and 5 partials ⚠️
internal/gateway/adapters/urlscheme/dispatcher.go 97.70% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@pionxe pionxe merged commit 5413113 into release/v2.0-split-build Apr 24, 2026
1 check passed
@fennoai fennoai Bot deleted the fork-pr-423-1776999056 branch April 24, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants