Add WAIT stage into lambda canary-example#3258
Merged
pipecd-bot merged 1 commit intopipe-cd:masterfrom Feb 15, 2022
Merged
Conversation
Without this, it will immediately promote to 100%. Normally, in a canary release scenario, you should wait for a while.
Member
|
Thank you. |
Collaborator
|
Code coverage for golang is |
Member
|
Nice catch! |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
chaspy
changed the title
This was referenced Feb 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is for the help of users trying out the example.
Without this, it will immediately promote to 100%.
Normally, in a canary release scenario, you should wait for a while.
I've confirmed the pipeline works expectedly.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: