Conversation
…dencies Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
requested review from
ffjlabo,
kentakozuka,
khanhtc1202,
nghialv and
t-kikuc
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5381 +/- ##
==========================================
- Coverage 25.76% 25.75% -0.02%
==========================================
Files 445 445
Lines 47947 47955 +8
==========================================
- Hits 12355 12351 -4
- Misses 34630 34641 +11
- Partials 962 963 +1 ☔ View full report in Codecov by Sentry. |
ffjlabo
reviewed
Dec 3, 2024
Member
ffjlabo
left a comment
ffjlabo
left a comment
There was a problem hiding this comment.
Thank you for the refactor. I left imo comment 🙏
Comment on lines
+71
to
+76
| toolRegistry toolRegistry, | ||
| logPersister logPersister, | ||
| ) *DeploymentService { | ||
| return &DeploymentService{ | ||
| RegexPool: regexpool.DefaultPool(), | ||
| Logger: logger.Named("planner"), | ||
| ToolRegistry: nil, // TODO: set the tool registry | ||
| logger: logger.Named("planner"), | ||
| loader: provider.NewLoader(toolregistry.NewRegistry(toolRegistry)), |
Member
There was a problem hiding this comment.
IMO: How about changing the interface name of toolRegistry to toolClient?
At first, I was confused that it created a new tool Registry with tool registry.
Member
Author
There was a problem hiding this comment.
I agree that it's confusing. I'll rename it as you suggested. Thanks.
Member
Author
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
t-kikuc
approved these changes
Dec 3, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Why we need it:
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: No