Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5384 +/- ##
==========================================
- Coverage 25.82% 25.72% -0.11%
==========================================
Files 445 446 +1
Lines 47859 48141 +282
==========================================
+ Hits 12361 12382 +21
- Misses 34536 34787 +251
- Partials 962 972 +10 ☔ View full report in Codecov by Sentry. |
t-kikuc
approved these changes
Dec 3, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add context to the RunBinary interface to have more control.
Also, add test for the DownloadBinary function.
Why we need it:
Instead of
context.Background, use context passed by the run binary caller side would gain the caller more control on the binary lifecycle.Which issue(s) this PR fixes:
Part of #4980
Follows #5361
Does this PR introduce a user-facing change?: