added arm64 build for piped-base and other images#5395
added arm64 build for piped-base and other images#5395t-kikuc merged 10 commits intopipe-cd:masterfrom
Conversation
Signed-off-by: ponkio-o <29038315+ponkio-o@users.noreply.github.com>
Signed-off-by: ponkio-o <29038315+ponkio-o@users.noreply.github.com>
Signed-off-by: ponkio-o <29038315+ponkio-o@users.noreply.github.com>
…f google/clodu-sdk Signed-off-by: ponkio-o <29038315+ponkio-o@users.noreply.github.com>
| ARG GOOGLE_CLOUD_SDK_VERSION=392.0.0-alpine | ||
|
|
||
| FROM google/cloud-sdk:$GOOGLE_CLOUD_SDK_VERSION | ||
| FROM gcr.io/google.com/cloudsdktool/google-cloud-cli:$GOOGLE_CLOUD_SDK_VERSION |
There was a problem hiding this comment.
Container image was changed. Because google/cloud-sdk doesn't support arm64.
https://cloud.google.com/sdk/docs/downloads-docker
$ uname -m
arm64
$ docker inspect google/cloud-sdk:392.0.0-alpine | jq -r .[].Architecture
amd64
$ docker inspect gcr.io/google.com/cloudsdktool/google-cloud-cli:392.0.0-alpine | jq .[].Architecture
arm64And I checked working correctly when use it.
$ docker build -t firestore-emulator:local-test .
$ git diff
diff --git a/test/integration/datastore/firestore/main_test.go b/test/integration/datastore/firestore/main_test.go
index 3978f304..b7ed6acb 100644
--- a/test/integration/datastore/firestore/main_test.go
+++ b/test/integration/datastore/firestore/main_test.go
@@ -30,8 +30,8 @@ import (
const (
env = "FIRESTORE_EMULATOR_HOST"
port = "8080"
- repository = "ghcr.io/pipe-cd/firestore-emulator"
- tag = "v0.34.0-3-gf22c209"
+ repository = "firestore-emulator"
+ tag = "local-test"
project = "pipecd-test"
)
$ go test . -v
=== RUN TestGet
=== RUN TestGet/entity_found
=== RUN TestGet/not_found
--- PASS: TestGet (1.80s)
--- PASS: TestGet/entity_found (0.00s)
--- PASS: TestGet/not_found (0.00s)
=== RUN TestFind
=== RUN TestFind/fetch_all
=== RUN TestFind/fetch_by_name
=== RUN TestFind/only_cursor_given
--- PASS: TestFind (0.04s)
--- PASS: TestFind/fetch_all (0.02s)
--- PASS: TestFind/fetch_by_name (0.01s)
--- PASS: TestFind/only_cursor_given (0.00s)
=== RUN TestCreate
=== RUN TestCreate/already_exists
=== RUN TestCreate/successful_create
--- PASS: TestCreate (0.02s)
--- PASS: TestCreate/already_exists (0.01s)
--- PASS: TestCreate/successful_create (0.01s)
=== RUN TestUpdate
=== RUN TestUpdate/not_found
=== RUN TestUpdate/unable_to_update
=== RUN TestUpdate/successful_update
--- PASS: TestUpdate (0.03s)
--- PASS: TestUpdate/not_found (0.01s)
--- PASS: TestUpdate/unable_to_update (0.01s)
--- PASS: TestUpdate/successful_update (0.01s)
PASS
ok github.com/pipe-cd/pipecd/test/integration/datastore/firestore 3.651sThere was a problem hiding this comment.
Can't use latest version? If I can't use this version, I'll revert version of actions/checkout and docker/build-push-acion.

https://github.com/pipe-cd/pipecd/actions/runs/12198639429
There was a problem hiding this comment.
Thank you for your contribution!
I added them to the allowlist.
|
@ponkio-o I updated the branch to run the build_tool workflow. |
Signed-off-by: ponkio-o <29038315+ponkio-o@users.noreply.github.com>
Warashi
left a comment
There was a problem hiding this comment.
I added them to the allowlist and ran the build_tool workflow.
The workflow succeeded! Thank you!
https://github.com/pipe-cd/pipecd/actions/runs/12246423657?pr=5395
What this PR does: added
linux/arm64build for tool imagesWhy we need it: I'm currently working on arm64 support. First, I added an arm64 build to the container image under the
toolwhere piped-base and others are stored.Which issue(s) this PR fixes:
related: #4896
Does this PR introduce a user-facing change?: no