Merged
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
requested review from
ffjlabo,
kentakozuka,
khanhtc1202,
nghialv and
t-kikuc
as code owners
Warashi
commented
Dec 9, 2024
Comment on lines
+277
to
+278
| memberlist: | ||
| cluster_label: "{{ .Release.Name }}.{{ .Release.Namespace }}" |
Member
Author
There was a problem hiding this comment.
This change follows the upstream change.
grafana/helm-charts@e66f68a
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5396 +/- ##
==========================================
- Coverage 25.81% 25.80% -0.02%
==========================================
Files 450 450
Lines 48357 48357
==========================================
- Hits 12484 12478 -6
- Misses 34902 34908 +6
Partials 971 971 ☔ View full report in Codecov by Sentry. |
Warashi
changed the title
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
upgrade tempo chart
Why we need it:
I want to use the config below, introduced at Tempo v2.6.
The helm chart v1.10.2 points to Tempo v2.5.0, so I want to upgrade the chart.
ref; https://grafana.com/docs/tempo/latest/release-notes/v2-6/#operational-change-for-traceql-metrics
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: