Add metrics_generator_processors config to manifest#5397
Merged
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
requested review from
ffjlabo,
kentakozuka,
khanhtc1202,
nghialv and
t-kikuc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5397 +/- ##
=======================================
Coverage 25.74% 25.74%
=======================================
Files 449 449
Lines 48401 48401
=======================================
+ Hits 12459 12461 +2
+ Misses 34971 34968 -3
- Partials 971 972 +1 ☔ View full report in Codecov by Sentry. |
khanhtc1202
approved these changes
Dec 9, 2024
t-kikuc
approved these changes
Dec 9, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add config to Grafana Tempo's manifest to enable TraceQL metrics.
Why we need it:
I want to add this to get more verbose metrics about traces.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: