Fix the piped to correct invoking the k8s plugin#5401
Merged
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
khanhtc1202
approved these changes
Dec 10, 2024
t-kikuc
approved these changes
Dec 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5401 +/- ##
==========================================
- Coverage 25.73% 25.71% -0.03%
==========================================
Files 449 449
Lines 48452 48452
==========================================
- Hits 12470 12460 -10
- Misses 35008 35020 +12
+ Partials 974 972 -2 ☔ View full report in Codecov by Sentry. |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
Without this PR, the pipedv1 cannot invoke the k8s plugin.
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: No