Implement preparing the deploy source in pipedv1 planner / scheduler#5410
Merged
Implement preparing the deploy source in pipedv1 planner / scheduler#5410
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5410 +/- ##
==========================================
- Coverage 25.95% 25.95% -0.01%
==========================================
Files 451 451
Lines 48731 48793 +62
==========================================
+ Hits 12649 12663 +14
- Misses 35081 35124 +43
- Partials 1001 1006 +5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
…rface Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
khanhtc1202
reviewed
Dec 13, 2024
khanhtc1202
requested review from
ffjlabo,
kentakozuka,
nghialv and
t-kikuc
as code owners
t-kikuc
approved these changes
Dec 13, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Why we need it:
without this PR, we cannot plan/execute the deployment
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: No