Skip to content

Remove decryption grpc from pipedv1 plugin api#5414

Merged
khanhtc1202 merged 1 commit intomasterfrom
remove-decryption-grpc
Dec 12, 2024
Merged

Remove decryption grpc from pipedv1 plugin api#5414
khanhtc1202 merged 1 commit intomasterfrom
remove-decryption-grpc

Conversation

@khanhtc1202
Copy link
Member

What this PR does:

as title

Why we need it:

We agreed that Piped should be in charge of preparing the deploy source, and the plugin can just pull and use it. The plugins should not need to care whether the manifest is encrypted or not.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.80%. Comparing base (6b63206) to head (3ef7e36).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5414      +/-   ##
==========================================
- Coverage   25.82%   25.80%   -0.03%     
==========================================
  Files         450      449       -1     
  Lines       48520    48472      -48     
==========================================
- Hits        12530    12507      -23     
+ Misses      35013    34987      -26     
- Partials      977      978       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@khanhtc1202 khanhtc1202 merged commit 73db7c2 into master Dec 12, 2024
@khanhtc1202 khanhtc1202 deleted the remove-decryption-grpc branch December 12, 2024 09:31
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants