Skip to content

Move toolregistry package to pkg/plugin#5415

Merged
khanhtc1202 merged 1 commit intomasterfrom
refactor-piped-plugin-pkg
Dec 12, 2024
Merged

Move toolregistry package to pkg/plugin#5415
khanhtc1202 merged 1 commit intomasterfrom
refactor-piped-plugin-pkg

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Dec 12, 2024

What this PR does:

as title

Why we need it:

All the plugin shared packages should be placed under pkg/plugin and we can public it as the based for creating new plugin later.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@codecov
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.81%. Comparing base (73db7c2) to head (f91db1d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5415      +/-   ##
==========================================
- Coverage   25.82%   25.81%   -0.02%     
==========================================
  Files         449      449              
  Lines       48472    48472              
==========================================
- Hits        12517    12511       -6     
- Misses      34978    34984       +6     
  Partials      977      977              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khanhtc1202 khanhtc1202 merged commit a8527d2 into master Dec 12, 2024
@khanhtc1202 khanhtc1202 deleted the refactor-piped-plugin-pkg branch December 12, 2024 09:59
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants