Move toolregistry package to pkg/plugin#5415
Merged
khanhtc1202 merged 1 commit intomasterfrom Dec 12, 2024
Merged
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5415 +/- ##
==========================================
- Coverage 25.82% 25.81% -0.02%
==========================================
Files 449 449
Lines 48472 48472
==========================================
- Hits 12517 12511 -6
- Misses 34978 34984 +6
Partials 977 977 ☔ View full report in Codecov by Sentry. |
ffjlabo
approved these changes
Dec 12, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
All the plugin shared packages should be placed under
pkg/pluginand we can public it as the based for creating new plugin later.Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: