Add calling annotateConfigHash and refactor unmarshaling deploy target#5421
Merged
khanhtc1202 merged 5 commits intomasterfrom Dec 16, 2024
Merged
Add calling annotateConfigHash and refactor unmarshaling deploy target#5421khanhtc1202 merged 5 commits intomasterfrom
khanhtc1202 merged 5 commits intomasterfrom
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5421 +/- ##
==========================================
+ Coverage 25.96% 25.98% +0.01%
==========================================
Files 451 451
Lines 48793 48816 +23
==========================================
+ Hits 12669 12683 +14
- Misses 35118 35126 +8
- Partials 1006 1007 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
ffjlabo
reviewed
Dec 16, 2024
Member
ffjlabo
left a comment
There was a problem hiding this comment.
Almost all LGTM! I left just one nit comment.
Comment on lines
+91
to
+95
| if tt.expectedErr { | ||
| assert.Error(t, err) | ||
| } else { | ||
| assert.NoError(t, err) | ||
| } |
Member
There was a problem hiding this comment.
[nit]
Suggested change
| if tt.expectedErr { | |
| assert.Error(t, err) | |
| } else { | |
| assert.NoError(t, err) | |
| } | |
| assert.Equal(t, tt.expectedErr, err != nil) |
Member
Author
There was a problem hiding this comment.
I think my code provides more information when debugging the codes.
Your suggested code works fine when the test passes, but there is no information about the error when the test fails.
WDYT?
Member
There was a problem hiding this comment.
OK, there was a reason. got it. I also agree with that reason.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Why we need it:
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: