Use linter goheader to ensure license header exists#5435
Merged
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Member
Author
|
I ran |
Warashi
commented
Dec 19, 2024
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // http://www.apache.org/licenses/LICENSE-2.0 |
Member
Author
There was a problem hiding this comment.
changed hard tabs to spaces
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
Member
Author
There was a problem hiding this comment.
Without this empty line, gofmt converts heading spaces to tabs because they are treated as godoc comments
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5435 +/- ##
==========================================
- Coverage 26.10% 26.08% -0.02%
==========================================
Files 451 451
Lines 48837 48837
==========================================
- Hits 12748 12741 -7
- Misses 35072 35078 +6
- Partials 1017 1018 +1 ☔ View full report in Codecov by Sentry. |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
goheaderwithin the golangci-lint's configWhy we need it:
To ensure the license header exists
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: