Skip to content

Regenerate mock file using uber-go mock#5437

Merged
khanhtc1202 merged 8 commits intomasterfrom
update-go-mock
Dec 23, 2024
Merged

Regenerate mock file using uber-go mock#5437
khanhtc1202 merged 8 commits intomasterfrom
update-go-mock

Conversation

@khanhtc1202
Copy link
Member

What this PR does:

Update mock files by regenerating using the updated codegen image.
Also, fix the tests to use uber-go mock instead of golang mock.

Why we need it:

Which issue(s) this PR fixes:

Fixes #5429
Follow PR #5426

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 17.18310% with 294 lines in your changes missing coverage. Please review.

Project coverage is 26.26%. Comparing base (b98a963) to head (9b16319).
Report is 369 commits behind head on master.

Files with missing lines Patch % Lines
pkg/datastore/datastoretest/datastore.mock.go 6.12% 184 Missing ⚠️
pkg/git/gittest/git.mock.go 15.38% 44 Missing ⚠️
pkg/insight/insighttest/insight.mock.go 0.00% 25 Missing ⚠️
pkg/cache/cachetest/cache.mock.go 30.00% 21 Missing ⚠️
pkg/filestore/filestoretest/filestore.mock.go 40.00% 12 Missing ⚠️
pkg/jwt/jwttest/jwt.mock.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5437      +/-   ##
==========================================
+ Coverage   26.24%   26.26%   +0.02%     
==========================================
  Files         452      452              
  Lines       48860    48860              
==========================================
+ Hits        12821    12831      +10     
+ Misses      35014    35005       -9     
+ Partials     1025     1024       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) December 20, 2024 08:51
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202 khanhtc1202 merged commit bcdba1f into master Dec 23, 2024
@khanhtc1202 khanhtc1202 deleted the update-go-mock branch December 23, 2024 01:08
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to use uber-go mock instead

3 participants