Skip to content

Reduce ResourceKey's responsibility#5451

Merged
Warashi merged 10 commits intomasterfrom
refactor-remove-resource-key-methods
Dec 25, 2024
Merged

Reduce ResourceKey's responsibility#5451
Warashi merged 10 commits intomasterfrom
refactor-remove-resource-key-methods

Conversation

@Warashi
Copy link
Member

@Warashi Warashi commented Dec 25, 2024

What this PR does:

  • move the ResourceKey's method IsDeployment, IsConfigMap, and IsSecret to Manifest's method.

Why we need it:

I want to change ResourceKey's fields, and I want it to have fewer responsibilities.
I want the ResourceKey to be responsible only for identifying the resource.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

…igMap

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
…thods

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@codecov
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.15%. Comparing base (336d96d) to head (32708fd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5451      +/-   ##
==========================================
- Coverage   26.16%   26.15%   -0.02%     
==========================================
  Files         456      456              
  Lines       49009    48992      -17     
==========================================
- Hits        12825    12814      -11     
+ Misses      35160    35156       -4     
+ Partials     1024     1022       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi enabled auto-merge (squash) December 25, 2024 04:20
@Warashi Warashi merged commit 792015b into master Dec 25, 2024
@Warashi Warashi deleted the refactor-remove-resource-key-methods branch December 25, 2024 08:05
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants