Skip to content

Refactor wait plugin: rename package and file#5462

Merged
t-kikuc merged 2 commits intomasterfrom
refactor-rename-wait
Dec 27, 2024
Merged

Refactor wait plugin: rename package and file#5462
t-kikuc merged 2 commits intomasterfrom
refactor-rename-wait

Conversation

@t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Dec 27, 2024

What this PR does:

  • Rename execute package to deployment
  • Rename server.go to plugin.go

Why we need it:

For name consistency.

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.12%. Comparing base (77664e1) to head (b57e6b8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/plugin/wait/plugin.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5462      +/-   ##
==========================================
- Coverage   26.14%   26.12%   -0.03%     
==========================================
  Files         457      457              
  Lines       49107    49107              
==========================================
- Hits        12841    12831      -10     
- Misses      35244    35253       +9     
- Partials     1022     1023       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@t-kikuc t-kikuc merged commit 47a13c3 into master Dec 27, 2024
@t-kikuc t-kikuc deleted the refactor-rename-wait branch December 27, 2024 07:47
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants