Move PipedPluginService definition to the under the pkg/plugin#5468
Merged
Move PipedPluginService definition to the under the pkg/plugin#5468
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
requested review from
ffjlabo,
kentakozuka,
khanhtc1202,
nghialv and
t-kikuc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5468 +/- ##
=======================================
Coverage 26.19% 26.19%
=======================================
Files 458 458
Lines 49169 49169
=======================================
Hits 12881 12881
Misses 35266 35266
Partials 1022 1022 ☔ View full report in Codecov by Sentry. |
t-kikuc
approved these changes
Jan 7, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
It's weird that the plugins have to depend on the package under the
pkg/app/pipedv1/cmd/piped, so I moved the package.Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: No