fix: remove error disableBackdropClick is deprecated#5503
Merged
Conversation
hongky-1994
requested review from
Warashi,
ffjlabo,
khanhtc1202 and
t-kikuc
as code owners
Member
|
@hongky-1994 Thanks for the contribute 🎉 Please sign off the commit follow the github actions's log https://github.com/pipe-cd/pipecd/pull/5503/checks?check_run_id=35924678119 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5503 +/- ##
=======================================
Coverage 26.28% 26.29%
=======================================
Files 464 464
Lines 49624 49624
=======================================
+ Hits 13043 13047 +4
+ Misses 35547 35544 -3
+ Partials 1034 1033 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: kypham <hongkyhvnh@gmail.com>
hongky-1994
force-pushed
the
fix/depreated-disableBackdropClick-error
branch
from
1d2d909 to
96dcca5
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Why we need it:
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: