[WAIT] Implement server plan methods of Wait plugin#5504
Closed
[WAIT] Implement server plan methods of Wait plugin#5504
Conversation
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5504 +/- ##
==========================================
+ Coverage 26.28% 26.59% +0.31%
==========================================
Files 464 464
Lines 49624 49942 +318
==========================================
+ Hits 13043 13284 +241
- Misses 35547 35597 +50
- Partials 1034 1061 +27 ☔ View full report in Codecov by Sentry. |
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
23 tasks
Member
Author
|
I'll create another PR using the SDK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implemented the following methods:
Why we need it:
to plan wait stages
Note
[IMO] It'd be better to set values of the following variables of BuildQuick(or Pipeline)SyncStagesResponse on piped planner side:
StatusCreatedAtUpdatedAtThat's because plugins should not set wrong values and they're not related to plugin behavior.
Which issue(s) this PR fixes:
Part of #5367
Does this PR introduce a user-facing change?: