Fix docs: remote config other than Git is already available#5508
Merged
Fix docs: remote config other than Git is already available#5508
Conversation
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
t-kikuc
requested review from
Warashi,
ffjlabo and
khanhtc1202
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5508 +/- ##
=======================================
Coverage 26.28% 26.28%
=======================================
Files 464 464
Lines 49635 49635
=======================================
Hits 13047 13047
Misses 35555 35555
Partials 1033 1033 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Remove the following sentence.
And added the link to RuntimeOptions.
Why we need it:
Remote config other than Git repo is already available.
(e.g. GCP Secret Manager, AWS Secrets Manager, AWS SSM Parameter Store.)
Available locations are described on the RuntimeOptions page.
https://pipecd.dev/docs-v0.50.x/user-guide/managing-piped/runtime-options/#options-for-launcher
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: