Remove PlatformProvider from pipedv1 config#5511
Merged
khanhtc1202 merged 2 commits intomasterfrom Jan 30, 2025
Merged
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5511 +/- ##
==========================================
- Coverage 26.19% 26.10% -0.10%
==========================================
Files 464 464
Lines 49815 49684 -131
==========================================
- Hits 13049 12969 -80
+ Misses 35733 35687 -46
+ Partials 1033 1028 -5 ☔ View full report in Codecov by Sentry. |
Member
|
It seems good. How about creating a list of deprecated features in pipedv1 somewhere so that we can announce them without omission? (e.g. Issue? Label?) |
Member
Author
|
@t-kikuc That sound good, let do it separately, since this removal change in this PR does not related to deprecated features or not 👀 |
Member
|
Yes, of course do it separately. |
t-kikuc
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
The PlatformProvider and CloudProvider are no more be used in pipedv1 config
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: