Mark PlatformProvider as deprecated in models#5512
Merged
khanhtc1202 merged 1 commit intomasterfrom Jan 24, 2025
Merged
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
khanhtc1202
requested review from
Warashi,
ffjlabo and
t-kikuc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5512 +/- ##
=======================================
Coverage 26.19% 26.19%
=======================================
Files 464 464
Lines 49815 49815
=======================================
Hits 13049 13049
Misses 35733 35733
Partials 1033 1033 ☔ View full report in Codecov by Sentry. |
ffjlabo
approved these changes
Jan 24, 2025
Warashi
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Mark Platform Provider as deprecated field in models: application, deployment, piped
Why we need it:
For pipedv1, the logic will no longer depend on platform providers. Instead, we will use plugins and deploy_targets.
The field is marked as deprecated so that data from pipedv0 can be stored normally
Which issue(s) this PR fixes:
Part of #5252
Does this PR introduce a user-facing change?: