Skip to content

Add event to trigger demo env deployment#5514

Merged
khanhtc1202 merged 2 commits intomasterfrom
add-demo-env-trigger-event
Jan 24, 2025
Merged

Add event to trigger demo env deployment#5514
khanhtc1202 merged 2 commits intomasterfrom
add-demo-env-trigger-event

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Jan 24, 2025

What this PR does:

as title
Also, this PR changes the workflow to ensure eventwatcher only send after all artifacts are built successfully

Why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
ffjlabo
ffjlabo previously approved these changes Jan 24, 2025
@khanhtc1202 khanhtc1202 disabled auto-merge January 24, 2025 10:30
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.52%. Comparing base (45d8a20) to head (d82abf0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5514   +/-   ##
=======================================
  Coverage   26.52%   26.52%           
=======================================
  Files         464      464           
  Lines       49917    49917           
=======================================
  Hits        13239    13239           
  Misses      35618    35618           
  Partials     1060     1060           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@khanhtc1202 khanhtc1202 merged commit fcc31a3 into master Jan 24, 2025
14 checks passed
@khanhtc1202 khanhtc1202 deleted the add-demo-env-trigger-event branch January 24, 2025 10:39
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants