Update application endpoints web api#5517
Merged
khanhtc1202 merged 1 commit intomasterfrom Jan 30, 2025
Merged
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
khanhtc1202
requested review from
Warashi,
ffjlabo and
t-kikuc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5517 +/- ##
=======================================
Coverage 26.53% 26.53%
=======================================
Files 464 464
Lines 49917 49917
=======================================
Hits 13243 13243
Misses 35615 35615
Partials 1059 1059 ☔ View full report in Codecov by Sentry. |
ffjlabo
approved these changes
Jan 30, 2025
This was referenced Jan 31, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Make platform providers and kinds not required for application-related endpoints (AddApplication, UpdateApplication) web API.
Why we need it:
Follow this comment (#5516 (comment)), we're updating the web UI to accept both pipedv0 and pipedv1, the applications which be registered by pipedv1 will have no platform nor kind, so we should update the web API to accept that.
Which issue(s) this PR fixes:
Part of #5252 #5509
Does this PR introduce a user-facing change?: