Correct notification route handling for stage events#5524
Merged
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
requested review from
ffjlabo,
khanhtc1202 and
t-kikuc
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5524 +/- ##
==========================================
- Coverage 26.43% 26.42% -0.02%
==========================================
Files 464 464
Lines 49790 49810 +20
==========================================
Hits 13163 13163
- Misses 35573 35593 +20
Partials 1054 1054 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR corrects notification route handling for stage execution events.
Follows #5440
Related to #5523
Why we need it:
Without this PR, users cannot control notifications for stage execution events.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: No, because the feature for stage execution events has not been released yet.