Merged
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
… plugins Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
…ization Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5529 +/- ##
==========================================
- Coverage 26.53% 26.33% -0.20%
==========================================
Files 464 467 +3
Lines 49917 50066 +149
==========================================
- Hits 13243 13183 -60
- Misses 35615 35828 +213
+ Partials 1059 1055 -4 ☔ View full report in Codecov by Sentry. |
…nal identification fields and unimplemented method stubs Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
commented
Feb 3, 2025
|
|
||
| // DeploymentPlugin is the interface that be implemented by a full-spec deployment plugin. | ||
| // This kind of plugin should implement all methods to manage resources and execute stages. | ||
| type DeploymentPlugin[Config any] interface { |
Member
Author
There was a problem hiding this comment.
The Config parameter is the plugin's config defined in piped's config.
Member
There was a problem hiding this comment.
Let's add a comment to explain that 👍
t-kikuc
reviewed
Feb 4, 2025
|
|
||
| // DeploymentPlugin is the interface that be implemented by a full-spec deployment plugin. | ||
| // This kind of plugin should implement all methods to manage resources and execute stages. | ||
| type DeploymentPlugin[Config any] interface { |
Member
There was a problem hiding this comment.
Let's add a comment to explain that 👍
…meter Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Co-authored-by: Tetsuya KIKUCHI <97105818+t-kikuc@users.noreply.github.com> Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
t-kikuc
previously approved these changes
Feb 4, 2025
Member
t-kikuc
left a comment
There was a problem hiding this comment.
LGTM
Let's sophisticate the SDK through implementing plugins.
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Member
Author
|
I updated the copyright notice year to 2025 since these files were added this year. |
t-kikuc
approved these changes
Feb 7, 2025
This was referenced Feb 19, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds an SDK for plugin implementation.
The implementation is partial, and I'll send other PRs to implement the rest.
Why we need it:
There are many boilerplates for implementing plugins.
What I want to be reviewed:
The API designs.
The users of this SDK will write codes like the one below.
Which issue(s) this PR fixes:
Part of #5530
Does this PR introduce a user-facing change?: No