Call runningDSP.Get when runningDSP is not nil#5541
Merged
Conversation
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5541 +/- ##
==========================================
+ Coverage 26.42% 26.45% +0.02%
==========================================
Files 465 465
Lines 49858 49860 +2
==========================================
+ Hits 13175 13188 +13
+ Misses 35629 35618 -11
Partials 1054 1054 ☔ View full report in Codecov by Sentry. |
t-kikuc
approved these changes
Feb 6, 2025
Member
t-kikuc
left a comment
There was a problem hiding this comment.
like here? i got it
pipecd/pkg/app/piped/controller/scheduler.go
Lines 257 to 267 in edcf430
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
I fixed to call
runningDSP.Getwhen runningDSP is not nil.Why we need it:
When first deploy, runningDSP is nil because previous running commit is not found.
So it led panic.
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: