Turn off future flag react-router-dom, update test#5546
Merged
khanhtc1202 merged 1 commit intomasterfrom Feb 6, 2025
Merged
Conversation
Signed-off-by: kypham <hongkyhvnh@gmail.com>
hongky-1994
requested review from
Warashi,
ffjlabo,
khanhtc1202 and
t-kikuc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5546 +/- ##
=======================================
Coverage 26.42% 26.42%
=======================================
Files 465 465
Lines 49905 49905
=======================================
Hits 13189 13189
Misses 35661 35661
Partials 1055 1055 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Why we need it:
There are too many warnings of future-flag to feature of react-router-dom v7.
We currently don't plan to upgrade react-router-dom to version 7. So this PR is disabe future-flag followed by allow users to opt out of deprecation warnings by setting flags to false remix-run/react-router#12441 to suppress warning
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: None