Skip to content

Pipedv1 reports plugins while report metadata#5552

Merged
khanhtc1202 merged 2 commits intomasterfrom
report-piped-metadata
Feb 7, 2025
Merged

Pipedv1 reports plugins while report metadata#5552
khanhtc1202 merged 2 commits intomasterfrom
report-piped-metadata

Conversation

@khanhtc1202
Copy link
Member

What this PR does:

as title

Why we need it:

Piped need to report plugins as it metadata, so we can use this info on Web UI application form

Which issue(s) this PR fixes:

Part of #5252
Follow #5545

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 26.44%. Comparing base (1e2231f) to head (d13f0a0).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/cmd/piped/piped.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5552      +/-   ##
==========================================
- Coverage   26.44%   26.44%   -0.01%     
==========================================
  Files         465      465              
  Lines       49862    49872      +10     
==========================================
  Hits        13188    13188              
- Misses      35620    35630      +10     
  Partials     1054     1054              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202 khanhtc1202 merged commit 65c1c3d into master Feb 7, 2025
12 of 14 checks passed
@khanhtc1202 khanhtc1202 deleted the report-piped-metadata branch February 7, 2025 08:47
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants