Skip to content

Update kubectl version in deployment examples to 1.32.2#5563

Merged
Warashi merged 1 commit intomasterfrom
examples-kubectl-version-upgrade
Feb 14, 2025
Merged

Update kubectl version in deployment examples to 1.32.2#5563
Warashi merged 1 commit intomasterfrom
examples-kubectl-version-upgrade

Conversation

@Warashi
Copy link
Member

@Warashi Warashi commented Feb 14, 2025

What this PR does:

as title

Why we need it:

We use examples in the k8s plugin test, but there is no binary release for kubectl 1.18.0 for aarch64-darwin. So, the test fails on macOS with Apple Silicon.

There is no need to specify that old version, so I upgraded it to the latest.
ref; https://kubernetes.io/releases/

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.32%. Comparing base (02092ce) to head (eafe662).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5563      +/-   ##
==========================================
+ Coverage   26.31%   26.32%   +0.01%     
==========================================
  Files         467      467              
  Lines       50099    50099              
==========================================
+ Hits        13183    13189       +6     
+ Misses      35861    35855       -6     
  Partials     1055     1055              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi marked this pull request as ready for review February 14, 2025 01:56
@Warashi Warashi enabled auto-merge (squash) February 14, 2025 02:22
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Warashi Warashi merged commit c70c829 into master Feb 14, 2025
18 checks passed
@Warashi Warashi deleted the examples-kubectl-version-upgrade branch February 14, 2025 02:33
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants